VAGOV-TEAM-100673: Removes navbar and replaces with subtitle. #20268

ryguyk · 2025-01-09T18:44:52Z

Description

Removes the navbar, as it is no longer needed.
In its place, adds a subtitle placeholder. The specific subtitle will be added as each page gets built.

Closes department-of-veterans-affairs/va.gov-team#100673

Testing done

Updates functional tests.
Manual tests to ensure change is made on all Form Builder pages.

Screenshots

Before

After

QA steps

As a user with role Form Builder user:

Navigate to /form-builder
- Validate that the navbar is no longer present.
- Validate that "Subtitle Placeholder" appears in its place

Definition of Done

Documentation has been updated, if applicable.
Tests have been added if necessary.
Automated tests have passed.
Code Quality Tests have passed.
Acceptance Criteria in related issue are met.
Manual Code Review Approved.
If there are field changes, front end output has been thoroughly checked.

Select Team for PR review

Is this PR blocked by another PR?

DO NOT MERGE

Does this PR need review from a Product Owner

Needs PO review

CMS user-facing announcement

Is an announcement needed to let editors know of this change?

Yes, and it's written in issue ____ and queued for publication.
- Merge and ping the UX writer so they are ready to publish after deployment
Yes, but it hasn't yet been written
- Don't merge yet -- ping the UX writer to write and queue content
No announcement is needed for this code change.
- Merge & carry on unburdened by announcements

github-actions · 2025-01-09T18:45:15Z

Checking composer.lock changes...

derekhouck

LGTM with the assurance that this is a placeholder and the current subtitles with be replaced with more appropriate copy before we ship.

derekhouck · 2025-01-09T19:31:21Z

docroot/modules/custom/va_gov_form_builder/templates/page--va-gov-form-builder.html.twig

-        </nav>
-      </div>
+      <h1 class="form-builder-title">Form Builder</h1>
+      <div class="form-builder-subtitle">{{ page.form_builder_page_data.subtitle }}</div>


Small thing, but it may be more semantically appropriate to use a p tag instead of a div. Not a blocker.

Using a p for anything that isn't a bona fide paragraph has always felt a bit odd to me, but I also recognize that div soup is not ideal either. I'm going to heed this advice and change to a p.

I agree that it's not a perfect fit, but it is what Yale recommended in their page on headings.

docroot/modules/custom/va_gov_form_builder/css/va_gov_form_builder.css

github-actions · 2025-01-09T20:04:38Z

Checking composer.lock changes...

ryguyk · 2025-01-09T20:05:50Z

LGTM with the assurance that this is a placeholder and the current subtitles with be replaced with more appropriate copy before we ship.

Yes, certainly. The logic to fetch and render the form title as the subtitle will come in later work. The hard-coded subtitles on the Home and Form Naming page will come as those pages are built.

github-actions · 2025-01-10T17:53:05Z

Checking composer.lock changes...

github-actions · 2025-01-13T16:11:49Z

Checking composer.lock changes...

va-cms-bot · 2025-01-13T16:47:45Z

Cypress Accessibility Violations

`/test-data-officiis`

ID: button-name
Impact: critical
Tags: cat.name-role-value, wcag2a, wcag412, section508, section508.22.a, TTv5, TT6.a, EN-301-549, EN-9.4.1.2, ACT
Description: Ensure buttons have discernible text
Help: Buttons must have discernible text
Nodes:

HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Page introduction' field" data-proofing-help="Add an introduction that helps visitors understand if information on the page is relevant to them."> <span aria-hidden="true">i</span> </button>
Impact: critical
Target: .field--name-field-intro-text-limited-html > .field__label > .proofing-element-help[role="tooltip"]
Summary: Fix any of the following:
Element does not have inner text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element does not have an implicit (wrapped) <label>
Element does not have an explicit <label>
Element's default semantics were not overridden with role="none" or role="presentation"
HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Generate a table of contents from major headings' field" data-proofing-help="By checking this box, all h2's below this point on the page will be linked with with anchor links. This helps users navigate content on very long pages. Do not check this box unless there is at least 2 h2's on the page.">
Impact: critical
Target: .field--name-field-table-of-contents-boolean > .field__label > .proofing-element-help[role="tooltip"]
Summary: Fix any of the following:
Element does not have inner text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element does not have an implicit (wrapped) <label>
Element does not have an explicit <label>
Element's default semantics were not overridden with role="none" or role="presentation"
HTML: <button class="proofing-element-help" role="tooltip" data-proofing-help-title="About 'Main content' field" data-proofing-help="The main body of the page, which appears below the featured content."> <span aria-hidden="true">i</span> </button>
Impact: critical
Target: button[data-proofing-help-title="About 'Main content' field"]
Summary: Fix any of the following:
Element does not have inner text that is visible to screen readers
aria-label attribute does not exist or is empty
aria-labelledby attribute does not exist, references elements that do not exist or references elements that are empty
Element has no title attribute
Element does not have an implicit (wrapped) <label>
Element does not have an explicit <label>
Element's default semantics were not overridden with role="none" or role="presentation"

ryguyk requested a review from a team as a code owner January 9, 2025 18:44

va-cms-bot temporarily deployed to Tugboat January 9, 2025 18:44 Destroyed

ryguyk requested a review from derekhouck January 9, 2025 18:45

derekhouck previously approved these changes Jan 9, 2025

View reviewed changes

ryguyk dismissed derekhouck’s stale review via 4e75536 January 9, 2025 20:04

va-cms-bot temporarily deployed to Tugboat January 9, 2025 20:04 Destroyed

derekhouck approved these changes Jan 9, 2025

View reviewed changes

va-cms-bot temporarily deployed to Tugboat January 10, 2025 08:44 Destroyed

ryguyk force-pushed the VAGOV-TEAM-100673-remove-navbar branch from 4e75536 to 8b16cde Compare January 10, 2025 17:52

va-cms-bot temporarily deployed to Tugboat January 10, 2025 17:52 Destroyed

va-cms-bot temporarily deployed to Tugboat January 11, 2025 08:43 Destroyed

va-cms-bot temporarily deployed to Tugboat January 12, 2025 08:43 Destroyed

va-cms-bot temporarily deployed to Tugboat January 13, 2025 08:42 Destroyed

ryguyk added 2 commits January 13, 2025 10:11

VAGOV-TEAM-100673: Removes navbar and replaces with subtitle.

c9ec4d4

Replace div with p on subtitle.

f8dd97b

ryguyk force-pushed the VAGOV-TEAM-100673-remove-navbar branch from 8b16cde to f8dd97b Compare January 13, 2025 16:11

va-cms-bot temporarily deployed to Tugboat January 13, 2025 16:11 Destroyed

ryguyk merged commit 88bdc2a into main Jan 13, 2025
18 checks passed

ryguyk deleted the VAGOV-TEAM-100673-remove-navbar branch January 13, 2025 18:09

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VAGOV-TEAM-100673: Removes navbar and replaces with subtitle. #20268

VAGOV-TEAM-100673: Removes navbar and replaces with subtitle. #20268

ryguyk commented Jan 9, 2025 •

edited by derekhouck

Loading

github-actions bot commented Jan 9, 2025

derekhouck left a comment

derekhouck Jan 9, 2025

ryguyk Jan 9, 2025

derekhouck Jan 9, 2025

github-actions bot commented Jan 9, 2025

ryguyk commented Jan 9, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 13, 2025

va-cms-bot commented Jan 13, 2025

VAGOV-TEAM-100673: Removes navbar and replaces with subtitle. #20268

VAGOV-TEAM-100673: Removes navbar and replaces with subtitle. #20268

Conversation

ryguyk commented Jan 9, 2025 • edited by derekhouck Loading

Description

Testing done

Screenshots

Before

After

QA steps

Definition of Done

Select Team for PR review

Is this PR blocked by another PR?

Does this PR need review from a Product Owner

CMS user-facing announcement

github-actions bot commented Jan 9, 2025

derekhouck left a comment

Choose a reason for hiding this comment

derekhouck Jan 9, 2025

Choose a reason for hiding this comment

ryguyk Jan 9, 2025

Choose a reason for hiding this comment

derekhouck Jan 9, 2025

Choose a reason for hiding this comment

github-actions bot commented Jan 9, 2025

ryguyk commented Jan 9, 2025

github-actions bot commented Jan 10, 2025

github-actions bot commented Jan 13, 2025

va-cms-bot commented Jan 13, 2025

Cypress Accessibility Violations

/test-data-officiis

ryguyk commented Jan 9, 2025 •

edited by derekhouck

Loading

`/test-data-officiis`